-
-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitLab policy error fix #1605
GitLab policy error fix #1605
Conversation
…verify their GitLab account when needed + Loading bar visual improvement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor changes, but olivier was working on the same piece of code, you will have to rebase on main (i already have merged his work)
Thank you for this important contribution (both bug fix and ui) !
* gitlab hosting connector with good current job id return * gitlab hosting connector with good current job id return 2 * gitlab hosting connector with good current job id return v3 * with setTimout problem corrected * with setTimout problem corrected 2 * with setTimout problem corrected 3 * with setTimout problem corrected 3 * with setTimout problem corrected 3 * with setTimout problem corrected 4 * with setTimout problem corrected 4 * with setTimout problem corrected 5 * with setTimout problem corrected 5 * with setTimout problem corrected 6 * with timer in variables --------- Co-authored-by: Ubuntu <[email protected]>
…verify their GitLab account when needed + Loading bar visual improvement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've merged the changes of Olivier and addressed the problems you pointed out!
This pull request allows the GitLab hosting connector to handle a case where the publication fails because the GitLab user is recent. The connector will check if it's plugged to the official GitLab instance, and if so, it will display a clear message inside the publication dialog, with a clickable link.
On a side note, the loading bar ( element) inside the publication dialog has been slightly improved.